Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved setting to always "View all images from X" is not saved but lost #4886

Closed
rcubetrac opened this issue Aug 24, 2015 · 13 comments
Closed

Comments

@rcubetrac
Copy link

Reported by michael heuberger on 24 Aug 2015 02:04 UTC as Trac ticket #1490504

Everytime Roundcube asks me whether to "Always show images from X" I hit that button but this confirmation of mine seems to be lost.

Next time I get another email from X, Roundcube is asking me again the same question. Looks like a bug.

Migrated-From: http://trac.roundcube.net/ticket/1490504

@rcubetrac
Copy link
Author

Comment by @alecpl on 24 Aug 2015 07:52 UTC

Works for me. Are you using more than the default sql addressbook? Did you try with disabled plugins. See if the contact is added to addressbook when you click "Always show images..." button.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 24 Aug 2015 07:52 UTC

=> later

@rcubetrac
Copy link
Author

Comment by michael heuberger on 25 Aug 2015 01:22 UTC

how do i find out if i am using more than the default sql addressbook? i only see my personal address book.

yes, the contact is added to my personal addressbook whenever i click "Always show images..." - still, this doesn't make a difference.

and how can i disable all plugins within one command?

@rcubetrac
Copy link
Author

Comment by @alecpl on 25 Aug 2015 05:59 UTC

Replying to michael.heuberger:

how do i find out if i am using more than the default sql addressbook? i only see my personal address book.

Then you're using default addressbook (most likely).

yes, the contact is added to my personal addressbook whenever i click "Always show images..." - still, this doesn't make a difference.

Enable sql_debug and see what queries are executed when you open the message.

and how can i disable all plugins within one command?

$config['plugins'] = array();

@rcubetrac
Copy link
Author

Comment by michael heuberger on 25 Aug 2015 21:41 UTC

How do I enable sql_debug?

And re: $config[= array() I honestly have no idea if it's currently like that.

I have some plugins in the /plugin folder, no entry for $config['plugins']('plugins']) = ... in the config but some plugins listed in the require block in the composer.json file.

Don't you have a PHP info page for Roundcube alone to list what plugins really are enabled so that I can disable them all? Because of the above "mess" with the plugin folder, config and composer it is difficult to give a clear answer.

@rcubetrac
Copy link
Author

Comment by @alecpl on 27 Aug 2015 18:30 UTC

$config['sql_debug'] = true;

@rcubetrac
Copy link
Author

Comment by @alecpl on 10 Sep 2015 14:26 UTC

I can confirm the issue but only if email address contains '-' or '+' characters. For email addresses that contain only letters/dots/@ it works. Is this your case?

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 10 Sep 2015 14:26 UTC

later => 1.1.3

@rcubetrac
Copy link
Author

Comment by @alecpl on 10 Sep 2015 14:42 UTC

Reassigning the milestone, as there's no issue in 1.1.

@rcubetrac
Copy link
Author

Milestone changed by @alecpl on 10 Sep 2015 14:42 UTC

1.1.3 => 1.2-beta

@rcubetrac
Copy link
Author

Comment by michael heuberger on 10 Sep 2015 21:51 UTC

no idea alec - difficult to test here. you should be able to verify this with unit tests i think.

@rcubetrac
Copy link
Author

Comment by @thomascube on 14 Sep 2015 18:10 UTC

Known senders are searched in exact match mode, thus we should use the original search string for comparison. Fixed in db390a2.

@rcubetrac
Copy link
Author

Status changed by @thomascube on 14 Sep 2015 18:10 UTC

new => closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant