Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support "old subject" variable in vacation #5258

Open
PF4Public opened this issue May 18, 2016 · 4 comments
Open

Support "old subject" variable in vacation #5258

PF4Public opened this issue May 18, 2016 · 4 comments

Comments

@PF4Public
Copy link

At first I thought to file this as an issue here, but later I thought what could be easier than adding
"if header :matches "Subject" "*" { set "subjwas" ": ${1}";}" to the vacation template and adding a pull request myself. Well, it turned out "would that it were so simple".
So my questions are:

  1. Is it useful as a feature to have some kind of checkbox which adds this to vacation so that users may use {$subjwas} in their response texts?
    You can tell that this could be easily achieved by adding specific rule in filters, but that's more frightening for common users, who might prefer having a checkbox for that.
  2. As I mentioned, I thought to implement this myself, but stumble across several issues:
    a) Vacation only checks for its very own single rule, but as far as I understand this particular line should have it's own rule, so that vacation_rule() should be significantly rewritten to accommodate for two rules. Is that true?
    b) Having added this rule as it is, I'm afraid it will fail to add "variables" as requirements. Is that true?
    c) May I ask someone to implement this? :)
@alecpl
Copy link
Member

alecpl commented May 18, 2016

RFC5230: 5.3. Subject
Users can specify the Subject of the reply with the ":subject"
parameter. If the :subject parameter is not supplied, then the
subject is generated as follows: The subject is set to the characters
"Auto: " followed by the original subject. An appropriate fixed
Subject, such as "Automated reply", SHOULD be used in the event that
:subject isn't specified and the original message doesn't contain a
Subject field.

What's wrong with not specifying :subject, so system uses "Auto: "? Isn't that working on your system? Or you want the original subject in the response text?

@PF4Public
Copy link
Author

I'd prefer prefix subject with more meaningful text, such as "On vacation: ", "Outer meeting: " as well as using native language, rather than English.
For instance, Exchange handles auto-responses that way and they look nicer compared to mere "Auto: "
To be honest, I didn't try omitting Subject completely, so that my system might properly generate "Auto: " subject, but that's not what I want.

@alecpl alecpl changed the title Is it useful to preserve old subject in vacation? Support "old subject" variable in vacation May 26, 2016
@Ratedev
Copy link

Ratedev commented Dec 1, 2016

+1 for this feature request

@alecpl alecpl added this to the later milestone Jan 7, 2018
@vendoremo
Copy link

+1 for this feature request

html support would also be nice here

another problem is that if field "reply-to" is not empty, auto-response is send to "from" e-mail anyway, usually to no-reply e-mail type in this situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants