Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) supports #6917

Open
Neustradamus opened this issue Sep 7, 2019 · 19 comments

Comments

@Neustradamus
Copy link

Neustradamus commented Sep 7, 2019

Dear @roundcube team,

Can you add supports of :

  • SCRAM-SHA-1
  • SCRAM-SHA-1-PLUS
  • SCRAM-SHA-256
  • SCRAM-SHA-256-PLUS
  • SCRAM-SHA-512
  • SCRAM-SHA-512-PLUS
  • SCRAM-SHA3-512
  • SCRAM-SHA3-512-PLUS

You can add too:

  • SCRAM-SHA-224
  • SCRAM-SHA-224-PLUS
  • SCRAM-SHA-384
  • SCRAM-SHA-384-PLUS

A "big" list has been done in last link of this ticket.


SCRAM-SHA-1(-PLUS):

SCRAM-SHA-256(-PLUS):

SCRAM-SHA-512(-PLUS):

SCRAM-SHA3-512(-PLUS):

SCRAM BIS: Salted Challenge Response Authentication Mechanism (SCRAM) SASL and GSS-API Mechanisms:

-PLUS variants:

IMAP:

LDAP:

  • RFC5803: Lightweight Directory Access Protocol (LDAP) Schema for Storing Salted: Challenge Response Authentication Mechanism (SCRAM) Secrets: https://tools.ietf.org/html/rfc5803

HTTP:

JMAP:

2FA:

IANA:

Linked to:

@alecpl
Copy link
Member

alecpl commented Sep 8, 2019

Auth_SASL has some SCRAM support so it should be doable, but I will not give it a high prio. Any help appreciated.

@Neustradamus
Copy link
Author

It can be ok for 1.4?

@alecpl
Copy link
Member

alecpl commented Sep 9, 2019

There's only one difference between these two libs. They handle errors differently. SO, there's no reason to switch.

@Neustradamus
Copy link
Author

What is missing for SCRAM in 1.4 RC1 for 1.4 release?

Note: SCRAM is for LDAP too.

@alecpl
Copy link
Member

alecpl commented Sep 9, 2019

  1. Make sure pear/Auth_SASL has everything you need. It might not support *-PLUS variants, but I didn't look at this.
  2. Add SCRAM auth support to rcube_imap_generic.
  3. Add SCRAM auth support to pear/Net_Sieve.
  4. Add SCRAM auth support to pear/Net_SMTP.
  5. Add SCRAM auth support to kolab/Net_LDAP3.

@Neustradamus
Copy link
Author

Yes, I think it is not supported yet for -PLUS variants, but it is already good point :)

@Neustradamus
Copy link
Author

@alecpl: Any news?
I have seen that Roundcube 1.4 is out!

@alecpl
Copy link
Member

alecpl commented Nov 16, 2019

I'm not working and not plan to work on this in foreseable future. It's not a prio for me. Pull requests appreciated.

@Neustradamus
Copy link
Author

@alecpl, @kanarip: Can you look for kolab/Net_LDAP3 and SCRAM?
I have looked here: https://git.kolab.org/diffusion/PNL/history/master/

@alecpl: Your are here too :)

I have done a ticket for pear/Net_SMTP: pear/Net_SMTP#57

For pear/Auth_SASL, all except -PLUS variants are good.

@Neustradamus Neustradamus changed the title SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) supports SCRAM-SHA-1-PLUS + SCRAM-SHA-256-PLUS + SCRAM-SHA-512-PLUS supports Nov 1, 2020
@Neustradamus Neustradamus changed the title SCRAM-SHA-1-PLUS + SCRAM-SHA-256-PLUS + SCRAM-SHA-512-PLUS supports SCRAM-SHA-1(-PLUS) + SCRAM-SHA-256(-PLUS) + SCRAM-SHA-512(-PLUS) supports Nov 1, 2020
@Neustradamus
Copy link
Author

@alecpl: Can you add "Issues" section (or it must be owner of PEAR) in https://github.com/pear/Net_Sieve?

Have you progressed on SCRAM?
To have a best security?

Note, after SCRAM-SHA-1(-PLUS):

@Neustradamus
Copy link
Author

@alecpl: SquirrelMail has SCRAM, it is possible to add in Roundcube?

@Neustradamus
Copy link
Author

@alecpl: Have you progressed on it?

@Neustradamus
Copy link
Author

Dear @roundcube team, @alecpl, @thomascube, @vbenincasa,

Happy New Year 2022!

Have you looked for SCRAM-SHA-* supports?
The first step is without -PLUS variants.

Thanks in advance.

cc: @jparise

@Neustradamus
Copy link
Author

I have forgotten to inform you, SCRAM-SHA-256/SCRAM-SHA-256-PLUS are in the new IMAP, I have added the last RFC in the description: RFC9051: Internet Message Access Protocol (IMAP) - Version 4rev2:

I wish you a good reading ^^

@pkolmann
Copy link

Please consider when implementing SCRAM-SHA-* that the whole SCRAM-algorithm should run on the Client, not the PHP on the server.

UseCase: Company Firewall with deep packet inspection should not get the plaintext password in the HTTPS traffic...

@Neustradamus
Copy link
Author

@roundcube team, @alecpl: Net_SMTP (with Auth_SASL/Auth_SASL2) has now SCRAM-SHA-* features, old mechanisms have been deprecated.
Not yet -PLUS variants but a big progress done by @schengawegga and you can use.

Can you look for rcube_imap_generic, Net_Sieve, Net_LDAP3?

@Neustradamus
Copy link
Author

@alecpl: Can you look for rcube_imap_generic, Net_Sieve, Net_LDAP3?

It is already in pear/Auth_SASL, pear/Net_SMTP:

Thanks in advance.

cc: @schengawegga.

@Neustradamus
Copy link
Author

Dear @karlitschek, @nextcloud team.

I wish you a Happy New Year 2024!

Can you add SCRAM supports in Roundcube and in Nextcloud?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants