Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Compose" in Addressbook section don't add all contacts in a group #6972

Closed
gabriel-curtino opened this issue Oct 17, 2019 · 2 comments
Closed

Comments

@gabriel-curtino
Copy link

gabriel-curtino commented Oct 17, 2019

There is an issue when you "Compose" a new message choosing a group with more 200+ contacts.

  1. Go Addreessbook section
  2. Select a group with 200+ contacts
  3. Click "Compose"

Only part of the list (~200) is added as recipients.

  • version 1.3.6
  • max_recipients has default value then no limit.
  • in other cases, all contacts are added as recipients: when Compose from Mail section or when you add manually the group in To, Cc and BCC.

CSV file with hundreds of dummy emails addresses in a group for testing

@alecpl
Copy link
Member

alecpl commented Oct 18, 2019

There's indeed a hard limit in the code set to 200. Most SMTP servers do not accept such a big number of recipients, a time to send so many messages could also exceed our request limit. I.e. it might cause some UI issues. That's probably the reason the limit is there.

I guess we could remove that limitation, and use max_group_members if set, otherwise no limit.

@alecpl alecpl added this to the later milestone Oct 18, 2019
@alecpl alecpl modified the milestones: later, 1.4.2 Dec 15, 2019
alecpl added a commit that referenced this issue Dec 15, 2019
…ecting to mail composer from Contacts (#6972)

Use max_group_members with fallback to 999 if unset.
alecpl added a commit that referenced this issue Dec 15, 2019
…ecting to mail composer from Contacts (#6972)

Use max_group_members with fallback to 999 if unset.
@alecpl
Copy link
Member

alecpl commented Dec 15, 2019

Fixed.

@alecpl alecpl closed this as completed Dec 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants