Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing bootstrap.min.css.map in elastic skin #7035

Closed
xkill opened this issue Nov 14, 2019 · 4 comments
Closed

Missing bootstrap.min.css.map in elastic skin #7035

xkill opened this issue Nov 14, 2019 · 4 comments
Milestone

Comments

@xkill
Copy link

xkill commented Nov 14, 2019

Hi,

I just upgraded my Roundcube installation to 1.4.0 and activated the elastic skin. I noted, on the browser console, that the bootstrap.min.css.map is not included on the roundcube complete tar.gz and it is referred on the file bootstrap.min.css.

# tail -n1 skins/elastic/deps/bootstrap.min.css
/*# sourceMappingURL=bootstrap.min.css.map */

I also noted that the bootstrap.bundle.min.js.map is missing:

tail -n1 skins/elastic/deps/bootstrap.bundle.min.js 
//# sourceMappingURL=bootstrap.bundle.min.js.map
@alecpl
Copy link
Member

alecpl commented Nov 15, 2019

I'm not sure we should provide these. It is additional 800KB (150KB gzipped). @thomascube what do you think?

ps. we're using vanilla Bootstrap releases, so you can get these files from Bootstrap if you really need them.

@thomascube
Copy link
Member

Nope, I don't think we should include them. Browsers anyway only request them when opening the console. For release package, we could consider to strip the comments off the bundled files.

@thomascube
Copy link
Member

Maybe we can make this a feature of install-jsdeps.sh

@alecpl
Copy link
Member

alecpl commented Nov 24, 2019

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants