Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Password: Incorrect escaping of username argument in smb and kpasswd drivers #7092

Closed
barrettkuo opened this issue Nov 29, 2019 · 2 comments
Closed

Password: Incorrect escaping of username argument in smb and kpasswd drivers #7092

barrettkuo opened this issue Nov 29, 2019 · 2 comments
Labels
bug C: Plugins
Milestone
1.4.2

Comments

@barrettkuo
Copy link

It worked well at version 1.3.xx but not working after version 1.4 .
I tested both upgrade from 1.3.xx and totally new installation.
All the result are failed.

error message:
PHP Error: Password plugin: Unable to execute /bin/kpasswd "'wtest'" 2>&1 in /usr/share/roundcubemail/plugins/password/
drivers/kpasswd.php on line 37 (POST /?_task=settings&_action=plugin.password-sa
ve)

If I downgrade to 1.3.xx from V1.4 , it works again.
@alecpl
Copy link
Member

alecpl commented Nov 29, 2019

Confirmed. There's indeed double-quoting caused by 60922dc#diff-ad24d10fbbd896cbb2f02c4d34c7fd1b

@alecpl alecpl added this to the 1.4.2 milestone Nov 29, 2019
alecpl added a commit that referenced this issue Nov 29, 2019
@alecpl
Password: Fix kpasswd and smb drivers' double-escaping bug (#7092)
e7cb9bf
@alecpl alecpl changed the title password plugin didn't work with kpasswd driver after V1.4 Password: Incorrect escaping of username argument in smb and kpasswd drivers Nov 29, 2019
alecpl added a commit that referenced this issue Nov 29, 2019
@alecpl
Password: Fix kpasswd and smb drivers' double-escaping bug (#7092)
132be94
@alecpl
Copy link
Member

alecpl commented Nov 29, 2019

Fixed.

@alecpl alecpl closed this as completed Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug C: Plugins
Projects
None yet
Milestone
1.4.2
Development

No branches or pull requests
2 participants
@alecpl @barrettkuo