Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish (Latin America) unusable #7784

Closed
chriskulbacki opened this issue Dec 15, 2020 · 4 comments
Closed

Spanish (Latin America) unusable #7784

chriskulbacki opened this issue Dec 15, 2020 · 4 comments

Comments

@chriskulbacki
Copy link
Contributor

Hi all,
Just wanted to mention that the language Spanish (Latin America) never gets saved in the Roundcube preferences.

The code for Spanish (Latin America) is 'es_418':

program/localization/index.inc:
'es_419' => 'Spanish (Latin America)',

...while during the saving process digits are not allowed:

program/steps/settings/save_prefs.inc
'language' => rcmail_prefs_input('language', '/^[a-zA-Z_-]+$/'),

Also, 'es_419' is 6 characters, while the type of the language column in the 'users' database table is varchar(5), so that probably should get updated as well.

@alecpl
Copy link
Member

alecpl commented Dec 15, 2020

Duplicate of #6851.

@alecpl alecpl closed this as completed Dec 15, 2020
@thomascube
Copy link
Member

thomascube commented Dec 17, 2020

@alecpl What about the regex check in rcmail_action_settings_prefs_save aka save_prefs.inc?

@thomascube thomascube reopened this Dec 17, 2020
@alecpl
Copy link
Member

alecpl commented Dec 17, 2020

Oh, I missed the regex part.

@alecpl
Copy link
Member

alecpl commented Dec 19, 2020

Fixed.

@alecpl alecpl closed this as completed Dec 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants