Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip TYPE=OTHER from QR contact export #8838

Closed
dilyanpalauzov opened this issue Dec 28, 2022 · 4 comments
Closed

strip TYPE=OTHER from QR contact export #8838

dilyanpalauzov opened this issue Dec 28, 2022 · 4 comments

Comments

@dilyanpalauzov
Copy link
Contributor

When I view the raw data of QR codes, exported by Roundcube 1.6.0 ,they contain lines like

EMAIL;TYPE=INTERNET;TYPE=OTHER:x@y.z
EMAIL;TYPE=INTERNET;TYPE=WORK:a@b.c
TEL:TYPE=other:+123 456
EMAIL:TYPE=INTERNET;TYPE=HOME:mm@nn.pp
  • Please remove TYPE=OTHER from the QR code, this is not defined and only adds extra data.
  • Consider removing TYPE=INTERNET. vCard data exchange works perfectly well without spelling explicitly TYPE=INTERNET
  • In case TYPE=INTERNET will be kept, please combine TYPE=INTERNET;TYPE=HOME: into TYPE=INTERNET,HOME:

As removig TYPE=OTHER reduces the transferred data over the QR image, please consider exporting to QR something else in addition, e.g. birthday of the contact

@dilyanpalauzov
Copy link
Contributor Author

See also mstilkerich/rcmcarddav#412 .

@alecpl
Copy link
Member

alecpl commented Dec 31, 2022

TYPE=OTHER is indeed not standard, so we should probably drop it. Dropping TYPE=INTERNET also makes sense as it is a default in vCard v3, and does not exist in v4.

@dilyanpalauzov
Copy link
Contributor Author

How is rcmcarddav supposed to inject contacts into Rouncube-addressbooks without sending TYPE=OTHER?

LDAP does also inject contacts into the roundcube addressbooks, but when these are exported over QR-code do not contain TYPE=OTHER, just TYPE=INTERNET.

@alecpl alecpl modified the milestones: later, 1.6.2 Apr 10, 2023
alecpl added a commit that referenced this issue Apr 10, 2023
alecpl added a commit that referenced this issue Apr 10, 2023
@alecpl
Copy link
Member

alecpl commented Apr 10, 2023

Fixed.

@alecpl alecpl closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants