Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipient label text is partially unvisible in Finnish locale #8905

Closed
reflektoin opened this issue Jan 31, 2023 · 2 comments
Closed

Recipient label text is partially unvisible in Finnish locale #8905

reflektoin opened this issue Jan 31, 2023 · 2 comments

Comments

@reflektoin
Copy link

Thank you for developing this software!

Here's an image of the issue:
The text left to the form field is partially blocked by the text field. The last letter is not completely visible.

roundcube_recipient_edit_fi

Steps to reproduce:

  1. Change User interface language to Finnish.
  2. Compose new message.
  3. Add a recipient.
  4. Double click the recipient.

Similar view as in the attached image should be now visible.

In English the "Vastaanottajan muokkaus" is "Recipient Edit".

@alecpl
Copy link
Member

alecpl commented Feb 1, 2023

The css is the same for all single-input dialogs, e.g. Add Group. So, we need to fix it in a universal way.

I see three solutions:

  1. Use col-sm-3/col-sm-9 instead of col-sm-2/col-sm-10.
  2. Use text-truncate class on the label.
  3. Use text-break class on the label.

I'm not sure which I like the best.

$('<div class="form-group row">')
.append(label.attr('for', id).addClass('col-sm-2 col-form-label'))
.append($('<div class="col-sm-10">').append(input))

@alecpl alecpl added this to the later milestone Feb 1, 2023
@alecpl alecpl modified the milestones: later, 1.6.2 Mar 19, 2023
alecpl added a commit that referenced this issue Mar 19, 2023
alecpl added a commit that referenced this issue Mar 19, 2023
@alecpl
Copy link
Member

alecpl commented Mar 19, 2023

Fixed.

@alecpl alecpl closed this as completed Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants