Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: OAuth and local SMTP (port 25, no SSL/TSL) without authentication #9183

Closed
sphakka opened this issue Oct 24, 2023 · 3 comments
Closed

Comments

@sphakka
Copy link

sphakka commented Oct 24, 2023

I've been using for years Roundcube with a local Postfix instance on port 25 to send e-mails without authentication. However, with OAuth this no longer works because RC enforces XOAUTH2 auth type plus credentials: indeed, (at least with Postfix 3.7.6 on Debian 12) during the SMTP handshake, no ''250-AUTH" is offered at all, thus the client (Roundcube) bails out. I guess that's correct SMTP behavior before the client issues a STARTTLS, which won't happen because Roundcube is configured with smtp_host = 'localhost:25'.

Thus, I wonder if it could be OK to further extend RC's rcmail_oauth::smtp_connect() to skip authentication when explicitly requested, e.g., with smtp_auth_type = 'NONE', while possibly checking that we're on port 25 and no SSL/TLS was configured for SMTP.

What do you think?

P.S. OAuth + SMTP submission on tls://localhost:587 works as expected.

@alecpl
Copy link
Member

alecpl commented Oct 24, 2023

I suppose it should be enough to skip code in rcmail_oauth::smtp_connect() if smtp_user='' and smtp_pass=''.

@sphakka
Copy link
Author

sphakka commented Oct 24, 2023

I suppose it should be enough to skip code in rcmail_oauth::smtp_connect() if smtp_user='' and smtp_pass=''.

Thanks, I'll give it a try.

@alecpl alecpl added this to the later milestone Oct 29, 2023
@alecpl alecpl modified the milestones: later, 1.7-beta Dec 23, 2023
alecpl pushed a commit that referenced this issue Dec 23, 2023
@alecpl
Copy link
Member

alecpl commented Dec 23, 2023

Implemented.

@alecpl alecpl closed this as completed Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants