Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for DelSp=Yes messages #5702

Merged
merged 4 commits into from Mar 22, 2017
Merged

Add support for DelSp=Yes messages #5702

merged 4 commits into from Mar 22, 2017

Conversation

dfukagaw28
Copy link
Contributor

@dfukagaw28 dfukagaw28 commented Mar 21, 2017 •
edited

Currently RCM can not handle delsp=yes messages correctly.

When receiving a message with format=flowed;delsp=yes, RCM unfold the message body incorrectly.
For example, Round \r\nCube is unfolded into Round Cube although RoundCube is expected.

Some MUAs, including Thunderbird (>45.0), generate MIME messages with "format=flowed;delsp=yes" by default if the charset is set to be ISO-2022-JP.

MIME option delsp=yes is specified in RFC 3676
https://www.ietf.org/rfc/rfc3676.txt

If the line is flowed and DelSp is "yes", the trailing space immediately prior to the line's CRLF is logically deleted. If the DelSp parameter is "no" (or not specified, or set to an unrecognized value), the trailing space is not deleted.

The DelSp parameter was added specifically to permit Format=Flowed to be used with languages/coded character sets in which the ASCII space character is rarely used, or not used at all.

@alecpl
Copy link
Member

alecpl commented Mar 21, 2017

This looks to me as incomplete. Did you forget about other changes or not implemented them yet? I see you added an argument to unfolding function, but I don't see changes in the code that uses it.

@dfukagaw28
Copy link
Contributor Author

Yes, you are right.
I will put another commit which uses the unfolding function.
Thank you for your comment.

@dfukagaw28
Copy link
Contributor Author

I hope it works this time.

Note that this PR is just for unfolding (receiving) "DelSp=Yes" messages, not for generating (sending) them.

@alecpl
Copy link
Member

alecpl commented Mar 21, 2017

Looks good, but there are more places where delsp value need to be passed as an argument:
https://github.com/roundcube/roundcubemail/blob/master/program/steps/mail/compose.inc#L913
https://github.com/roundcube/roundcubemail/blob/master/program/steps/mail/compose.inc#L930

@dfukagaw28
Copy link
Contributor Author

Thanks again.
I realized that the fix is necessary to compose a appropriate reply to a message with DelSp=Yes.

@alecpl alecpl merged commit 89a4134 into roundcube:master Mar 22, 2017
@alecpl alecpl added this to the 1.3-rc milestone Mar 22, 2017
ZiBiS added a commit to ZiBiS/roundcubemail that referenced this pull request Apr 13, 2017
@ZiBiS
Merge branch 'master' of https://github.com/roundcube/roundcubemail
83c6dc3 
* 'master' of https://github.com/roundcube/roundcubemail: (36 commits)
  Remove note about mail() function
  Update changelog
  Revert "extend plugin password to avoid sudo (use ssh instead calling chpasswd) (roundcube#5654)"
  Add Log to STDOUT Feature (roundcube#5721)
  extend plugin password to avoid sudo (use ssh instead calling chpasswd) (roundcube#5654)
  Fix bug where base_dn setting was ignored inside group_filters (roundcube#5720)
  Bump Net_Socket version
  Installer: Fix DB schema initialization on MS SQL Server
  Update to TinyMCE 4.5.6
  Fix undesired effects when postgres database uses different timezone than PHP host (roundcube#5708)
  Fix bug where namespace prefix could not be truncated on folders list if show_real_foldernames=true (roundcube#5695)
  Fix (restore) Tab key behaviour in autocomplete popup (roundcube#5659)
  Fix regression in LDAP fuzzy search where it always used prefix search instead (roundcube#5713)
  Ignore js deps (roundcube#5704)
  Update changelog
  Add support for DelSp=Yes messages (roundcube#5702)
  Fix permission of temporary files and removal of them when generating thumbnails
  Remove redundant entry
  Fix require entry for crypt_gpg also in Enigma's composer.json
  Use jQuery 3.2.1
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug C: MIME parsing
Projects
None yet
Milestone
1.3-rc
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfukagaw28 @alecpl