Fix Elastic's folders settings toggle button in search #7653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abshoff
force-pushed
the
fix-elastics-folders-settings-toggle-button-in-search
branch
from
7f184f9
to
362cd20
Compare
alecpl
added a commit
that referenced
this pull request
Dec 20, 2020
…r state from the search result (#7653)
alecpl
added a commit
that referenced
this pull request
Dec 20, 2020
…r state from the search result (#7653)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #7652
For each search result, a new list element is created for which the child elements are cloned from the original folder list item. When cloning, the elements' IDs are also copied which breaks Bootstrap's checkbox construct.
This fix reuses a clonerow event that has been introduced for a similar problem when creating new folders.