Docker compose for testing #9525
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps to test (reproduceably) locally, it only depends on docker compose, no other tools. It uses standalone containers for the greenmail IMAP server and the standalone browser. The previous solution should still work, and all github workflows are untouched (yet).
So we don't have to specify them on the command line when we check codestyle locally.
|
I don't like docker and I have no clue about docker, but...
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't get the browser tests to run green locally, and felt uneasy about running a downloaded binary with superuser-rights (the IMAP-server) on my machine anyway. So I decided to build a testing setup with docker compose, which depends on external containers for the browser and the IMAP-server and helps to make the environment reproducecable. Additionally it is faster for repeated runs, because it doesn't repeatedly downloads the server-jar, installs the webdriver, etc.
And because more people might find it useful I'm posting this pull request.
We could also rebuild the automated testing workflows to use services (external containers) to speed things up. But before I do that I wanted to know if this gets merged or provokes discussion in the first place.
The container image needs to be built locally, currently. If this gets merged I'd set it up to be built repeatedly on github and to be downloadable.