Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Error in Default Folder Path #2

Merged
merged 1 commit into from
Jan 2, 2019
Merged

Fix Error in Default Folder Path #2

merged 1 commit into from
Jan 2, 2019

Conversation

FireController1847
Copy link
Contributor

Fixes #1

Cannot believe this has not been fixed yet. Super simple fix too.

@FireController1847
Fix Error in Default Folder Path
5cf2308 
Fixes routbisu#1 

Cannot believe this has not been fixed yet. Super simple fix too.
routbisu
routbisu approved these changes Jan 2, 2019
View reviewed changes
Copy link
Owner

@routbisu routbisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@routbisu routbisu merged commit d5c6435 into routbisu:master Jan 2, 2019
@routbisu
Copy link
Owner

routbisu commented Jan 2, 2019

Thanks https://github.com/FireController1847 for your help.
I have been busy so missed fixing this.
Happy to know that people are actually using this.

@FireController1847
Copy link
Contributor Author

No problem! I'm glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@routbisu routbisu routbisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-file-logger reverts to default if options.folderPath exists
3 participants
@FireController1847 @routbisu @rmast