Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace tile fade animation #114

Closed
wants to merge 35 commits into from
Closed

replace tile fade animation #114

wants to merge 35 commits into from

Conversation

incanus
Copy link
Contributor

@incanus incanus commented Apr 12, 2011

See discussion here. Basically this is a switch from doing a reveal animation on each tile to doing a fade animation on the tile renderer's sublayers. This has the same desired tile fade effect, but solves #96 and also allows a potential future toggling setting on the renderer if this behavior is not desired, as opposed to checking from each tile image.

@vyskocil
Copy link
Member

I tried the patch but I hadn't experienced much improvement, perhaps you did other tweaks to have better results ?
I experienced the best results when I replace kCATransitionReveal with kCATransitionFade in RMTileImage.m and set mapView.contents.tileDepth to 2. With these changes the new tiles are blended like if it there is 'mipmapping' in action.

@incanus
Copy link
Contributor Author

incanus commented Apr 19, 2011

Setting tileDepth isn't an option when you use alpha-transparent tiles.

When I revert my commit, I get the flash. When I add it, there is only a fade. Here's a video in simulator for each:

I made both within a few seconds of each other changing only this commit.

incanus and others added 26 commits April 27, 2011 17:22
 * only affected dateline when very far south (i.e., low x & y)
 * was accidentally removing all tiles instead
@incanus
Copy link
Contributor Author

incanus commented Oct 21, 2011

I'm going to close this pull request as:

  1. I didn't branch properly and this is tracking mapbox/master, which is way too much.
  2. My fix here is only noticeable on MBTiles tile sources. I'm going to be doing more work here for both local & web-based sources to try to improve the fade animations where possible. I'll open separate issues for that.

@incanus incanus closed this Oct 21, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants