Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more support for projected points #98

Merged
merged 5 commits into from Mar 24, 2011
Merged

Added more support for projected points #98

merged 5 commits into from Mar 24, 2011

Conversation

amjaliks
Copy link
Contributor

@amjaliks amjaliks commented Mar 2, 2011

Added method setProjectedContraintsSW:NE: to RMMapView class.
Added method addMarker:atProjectedPoint: to RMMarkerManager class.
Added function RMProjectedPointEqualToProjectedPoint.
Added property centerProjectedPoint to RMMapContents class.

P.S. It isn't a refactoring, it is an addition.

Added method setProjectedContraintsSW:NE: to RMMapView class.
Added method addMarker:atProjectedPoint: to RMMarkerManager class.
The function RMProjectedPointEqualToProjectedPoint checks whether two passed projected points are equal.
@hjon
Copy link
Contributor

hjon commented Mar 5, 2011

I actually tried setProjectedContraintsSW:NE: some time ago and it seemed that it didn't produce the same results as setConstraintsSW:NE: (when using coordinates and projected coordinates that should have been in the same location). I don't think this is your fault, as what you did looks fine and I would have done the same.

Have you tested this successfully? It's certainly possible that I messed up when I tested it.

@amjaliks
Copy link
Contributor Author

amjaliks commented Mar 5, 2011

I work on project where I operate with projected points (because, the source have some specific projection). This why I have added setProjectedContraintsSW:NE:. And, of course, I use in my project. It works perfectly.

setProjectedContraintsSW:NE: does the same as setConstraintsSW:NE: does. If you look at an old implementation of setConstraintsSW:NE: and a new setProjectedContraintsSW:NE:, you would see the only difference, that old method calculates projected points, while a new method them directly to ivars.

@amjaliks amjaliks merged commit 04fd8ff into route-me:master Mar 24, 2011
@incanus
Copy link
Contributor

incanus commented Apr 18, 2011

Why does this pull request & this commit make -[RMMarkerManager addMarker:AtLatLong:] deprecated if it's "just an addition"? That's a particularly useful method and it goes towards making route-me more MapKit-like in that it deals directly with latitude & longitude.

If desired, I can create a pull request with a patch to bring this back out of deprecated-land.

darinwilson referenced this pull request in linkmediainc/mapbox-ios-sdk Sep 4, 2012
darinwilson referenced this pull request in linkmediainc/mapbox-ios-sdk Sep 4, 2012
yarry referenced this pull request in yarry/route-me Dec 10, 2012
…ap-scroll

fix normal scrolling of map when annotations can be dragged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants