Add DecIpv4Hop and DecIpv6Hop Elements #87
Conversation
|
Wanted to get a trivial networking element in to make sure we're all on the same page. I'm not sure this belongs in the runtime, but I know it's one of the basic elements we'll want to provide. The warning generated in smoltcp seems to be referenced here, but nowhere else I can find: smoltcp-rs/smoltcp#242 |
Needed for smoltcp
eeverett6
force-pushed
the
eeverett-dec-ip-ttl-element
branch
from
b8dd83f
to
fe03bff
Compare
|
This is basically exactly what I was thinking. I think we are on the same page here. This could become an element on it's own if you want to resubmit the PR,. I'm not enamored with the name DecIPTTLElement, but renaming is easy to do later too. |
|
@scgruber just want to check with you as well before adding 0BSD as a compatible license for our dependencies. |
eeverett6
force-pushed
the
eeverett-dec-ip-ttl-element
branch
from
fe03bff
to
1171d40
Compare
eeverett6
changed the title
There was a problem hiding this comment.
I approve these changes, but I would like to get a 👍 from @scgruber about adding the new acceptable license. This one seems compatible with our license schema from my reading but I'd like another pass from someone more versed.
Adds elements to decrement the TTL of IPv4 and Ipv6 elements. Adds a dependency on smoltcp for packet processing. This is one of the basic transformation elements from the Click paper (DecIPTTL), see #14
eeverett6
force-pushed
the
eeverett-dec-ip-ttl-element
branch
from
1171d40
to
7097f04
Compare
Adds an element to decrement the TTL of an IPv4 packet. Adds a
dependency on smoltcp for packet processing.
This is one of the basic transformation elements from the Click paper,
see #14