New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow gravity to be set on resize_to_fill #17

Merged
merged 1 commit into from Jun 15, 2016

Conversation

Projects
None yet
2 participants
@nitsujw
Contributor

nitsujw commented Jun 14, 2016

When using resize_to_fill this allows the ability to set the gravity for the crop

README.md Outdated
@@ -30,12 +30,16 @@ Thumbnailing:
# Resize to fill
open("input.jpg") |> resize_to_fill("450x300") |> save
# Resize to fill with gravity
open("input.jpg") |> resize_to_fill("450x300", gravity: "Center") |> save

This comment has been minimized.

@talklittle

talklittle Jun 15, 2016

Collaborator

I think I'd expect, for consistency with the rest of the API:

open("input.jpg") |> resize_to_fill("450x300") |> gravity("Center") |> save

So the extra resize_to_fill/3 is kind of redundant.

@nitsujw nitsujw force-pushed the nitsujw:gravity branch from b342c20 to 2c0b0de Jun 15, 2016

@nitsujw nitsujw force-pushed the nitsujw:gravity branch from 2c0b0de to 1448797 Jun 15, 2016

@nitsujw

This comment has been minimized.

Contributor

nitsujw commented Jun 15, 2016

@talklittle yup good point - fixed

@talklittle talklittle merged commit 8a65929 into route:master Jun 15, 2016

@talklittle

This comment has been minimized.

Collaborator

talklittle commented Jun 15, 2016

@nitsujw Very cool. Thank you!

@nitsujw

This comment has been minimized.

Contributor

nitsujw commented Jun 15, 2016

@talklittle thank you for the extremely fast response :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment