Allow gravity to be set on resize_to_fill #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -30,12 +30,16 @@ Thumbnailing: | |||
|
|
|||
| # Resize to fill | |||
| open("input.jpg") |> resize_to_fill("450x300") |> save | |||
|
|
|||
| # Resize to fill with gravity | |||
| open("input.jpg") |> resize_to_fill("450x300", gravity: "Center") |> save | |||
There was a problem hiding this comment.
I think I'd expect, for consistency with the rest of the API:
open("input.jpg") |> resize_to_fill("450x300") |> gravity("Center") |> save
So the extra resize_to_fill/3 is kind of redundant.
|
@talklittle yup good point - fixed |
|
@nitsujw Very cool. Thank you! |
|
@talklittle thank you for the extremely fast response :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using resize_to_fill this allows the ability to set the gravity for the crop