Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advance ReadBuf when filling #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Advance ReadBuf when filling #10

wants to merge 2 commits into from

Conversation

nadenf
Copy link

@nadenf nadenf commented Jul 24, 2021 •
edited

@seanpianka .. Can you also review this.

I have been looking at routerify/stream-body#2 and this was the reason that I wasn't getting a response back from the create-channel.rs example.

@nadenf nadenf mentioned this pull request Jul 24, 2021
Closed
@seanpianka
Copy link
Member

seanpianka commented Jul 25, 2021 •
edited

Can you please add a /// SAFETY: justification to these changes? I would like to avoid introducing any new unsafe code into Routerify again that does not have a solid memory safety and soundness justification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nadenf @seanpianka