Fix tests on Windows and executables for multiple platforms using canteen-maven-plugin #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
canteen-maven-pluginto build executables for Linux, OSX and Windows. This is mainly useful for Windows, where this plugin was previously unusable.I have also fixed one test case that failed on Windows due to different line separators.
The example project (
grpc-kotlin-example-chatserver) references a version of this plugin on Maven Central, so naturally that project does not work on Windows yet. It will however do so once a version with these changes has been pushed to Maven Central and the version ingrpc-kotlin-example-chatserverhas been updated.