Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure mvn build step always runs #13

Closed
rovats opened this issue May 3, 2020 · 2 comments
Closed

Ensure mvn build step always runs #13

rovats opened this issue May 3, 2020 · 2 comments
Labels

Comments

@rovats
Copy link
Owner

rovats commented May 3, 2020

May be use a random number generator URL?

Before mvn clean package:

ADD randomURL /tmp/cachebust

@rovats rovats added enhancement New feature or request high-priority labels May 3, 2020
@rovats
Copy link
Owner Author

rovats commented May 4, 2020

quite tricky to bust docker cache only for specific instructions, we can use a url that generates random text, but that's probably not desirable (pinging out to a random url).

Probably best to use --no-cache docker option when running the docker build command if the build needs to be forced and the code hasn't changed (eg: if the database has been re-created).

In the normal case, the build will work fine as it uses Github api to figure out if code has changed, and builds the necessary parts again (mvn clean package will rerun if any file has changed in the repo).

rovats added a commit that referenced this issue May 8, 2020
@rovats
Copy link
Owner Author

rovats commented May 8, 2020

Added force_build_timestamp build arg, which can be used to selectively bust docker cache (for specific instructions).

@rovats rovats added the done label May 8, 2020
@rovats rovats closed this as completed May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant