Feature: dashboard analytics #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
DashboardArticleAnalyticscomponent. Other changes include:ARTICLES_QUERYtoDASHBOARD_ARTICLES_QUERY, which includes thearticlesoperation and themostViewedoperation.Dashboardto transition (using Vue transitions) between displayingDashboardLogoandDashboardArticleAnalytics+ the articles list upon initial navigation to theDashboard.Note: There is a bug in which tests that import .gql files are failing. I am not entirely sure of the cause of the bug, but it may be related to kulshekhar/ts-jest#815 or jestjs/jest#7868. The initial bug seems to be fixable by switching from using
vue-jestto process Vue files in jest to using jest-vue-preprocessor. Two new bugs seem to occur after making this change, described in these issues:The solution in the first issue seems to solve the first bug. I have not tried the proposed solution to the second bug. I intend to address these bugs in a follow up PR since they affect unrelated functionality in this PR and the tests would pass if jest was configured correctly.