Conversation
2 failing tests from the new test suite:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks @JakeChampion. Gonna investigate fixing these issues before merging
…referance as the other object
…not match the actual error
…claim.doesNotThrow
…tThrow to be used to assert whether the actual error is expected
I've made a lot of changes since the review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments
README.md
Outdated
|
||
Assert that `actual` is deeply equal to `expected`, as determined by the strict equality operator `===`. | ||
|
||
### proclaim.notStrictEqual( actual, expected, [message] ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to be notDeepStrictEqual
?
@@ -381,7 +390,7 @@ If you're opening issues related to these, please mention the version that the i | |||
License | |||
------- | |||
|
|||
Proclaim is licensed under the [MIT][info-license] license. | |||
Proclaim is licensed under the [MIT][info-license] license. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of this whitespace messes up README formatting. Could you add back or replace with an actual <br/>
? I've been meaning to for ages 😅
Made the changes requested by the reviewer, please re-review.
Fixes #35