Updating s3 xml response message parsing #462
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…responses while still returning the correct s3ObjectLocation value.
Awesome, please do @inventionlabsSydney :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating s3 XML response message parsing in order to allow unordered responses while still returning the correct s3ObjectLocation value.
Currently the first child of the first element is assumed to be the location of the s3 object. The s3 alternative Minio does have the same elements, but not in the same order.
In order to support both Minio and potential future changes in the s3 response a more targeted approach is suggested in this pull request.
Parsing changes based on:
C&c very welcome.