Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Support for Chrome #9

Open
zackmark29 opened this issue May 5, 2020 · 26 comments · Fixed by #34
Open

Support for Chrome #9

zackmark29 opened this issue May 5, 2020 · 26 comments · Fixed by #34

Comments

@zackmark29
Copy link

This is really great. I just found it today
Could you please support also for chrome extension?

@54ac
Copy link
Owner

54ac commented May 6, 2020

I'll look into it, but no promises.

@xplorr
Copy link

xplorr commented Oct 31, 2020

A Chrome/Chromium version would be welcome!

@54ac
Copy link
Owner

54ac commented Feb 18, 2021

I have attached a crx file to the v2.6.4 release. Let me know if it works if you're interested.

@xplorr
Copy link

xplorr commented Feb 18, 2021

crx file cannot be enabled in Chrome because it was not found in the extension store

@54ac
Copy link
Owner

54ac commented Feb 18, 2021

Yeah, you have to extract it and load it as an unpacked extension I think.

@xplorr
Copy link

xplorr commented Feb 19, 2021

Unpacked and loaded gives error:
found unexpected key 'browser_style' MSG_extText

{
	"description": "__MSG_extText__",
	"manifest_version": 2,
	"name": "The Stream Detector",
	"default_locale": "en",
	"version": "2.6.4",
	"permissions": [
		"<all_urls>",
		"tabs",
		"clipboardWrite",
		"notifications",
		"storage",
		"webRequest"
	],
	"background": {
		"scripts": ["background.js"]
	},
	"icons": {
		"16": "img/icon-dark-16.png",
		"48": "img/icon-dark-48.png",
		"96": "img/icon-dark-96.png"
	},
	"options_ui": {
		"browser_style": true,
		"open_in_tab": false,
		"page": "content/options.html"
	},
	"browser_action": {
		"browser_style": true,
		"default_title": "The Stream Detector",
		"default_popup": "content/popup.html",
		"default_icon": {
			"16": "img/icon-dark-16.png",
			"48": "img/icon-dark-48.png"
		},
		"theme_icons": [
			{
				"dark": "img/icon-dark-96.png",
				"light": "img/icon-light-96.png",
				"size": 96
			},
			{
				"dark": "img/icon-dark-48.png",
				"light": "img/icon-light-48.png",
				"size": 48
			},
			{
				"dark": "img/icon-dark-16.png",
				"light": "img/icon-light-16.png",
				"size": 16
			}
		]
	}
}

@xplorr
Copy link

xplorr commented Feb 19, 2021

But seems to work ok. Thx!

@54ac
Copy link
Owner

54ac commented Feb 19, 2021

As long as it works then it's all good. I've removed these lines from the file anyway as they're not currently very useful. Thanks for testing.

@xplorr
Copy link

xplorr commented Feb 19, 2021

Why not release it in the Chrome store?
It may be very useful for Chrome users.

@54ac
Copy link
Owner

54ac commented Feb 19, 2021

It costs money to publish stuff in the Chrome store and I'm not about that life.

@xplorr
Copy link

xplorr commented Feb 20, 2021

Thanks a lot for this Chrome extension!
I also tested in Edge and Chromium/Slimjet browsers and works.

@Bibbbi
Copy link

Bibbbi commented Apr 11, 2021

I found a bug in the Chrome extension the_stream_detector-2.7.4.crx

Uncaught ReferenceError: browser is not defined: background.js:212

https://i.imgur.com/laxD7eO.png

Fix it:

Find:
browser.commands.onCommand.addListener(cmd => {
Replace:
chrome.commands.onCommand.addListener(cmd => {

@54ac
Copy link
Owner

54ac commented Apr 11, 2021

My bad. I've updated the crx file in the releases tab, should be fine now.

@goooglefc
Copy link

The chrome extension doesn't pickup the correct Referer for embedded M3U streams.

I know you don't provide support for Chrome, but, if possible, please look into this.

@54ac
Copy link
Owner

54ac commented Nov 5, 2021

I doubt I will, but if I did, you'd have to be more descriptive. Which website, what is the referer, what should it be, is it different in Firefox, etc.

@54ac
Copy link
Owner

54ac commented Nov 5, 2021

The issue can be kept open for the time being.

@54ac 54ac reopened this Nov 5, 2021
@goooglefc
Copy link

As an example you can look at https://sportsonline.to/channels/pt/sporttv3.php
The actual referer for this stream is "https://sastreaming.net" but the extension just picks up the current URL as referer.
There are many more like this.
The firefox extension obviously works fine on links like these and displays the correct referer.

@54ac
Copy link
Owner

54ac commented Nov 6, 2021

I looked into it and it was a quick fix. Should be working fine in v2.8.7.

@goooglefc
Copy link

goooglefc commented Nov 6, 2021

So far so good.
Thank you.

@ghost
Copy link

ghost commented Jun 12, 2022

It costs money to publish stuff in the Chrome store and I'm not about that life.

I thought it's free to host extensions on web store. Is that not true?

@54ac
Copy link
Owner

54ac commented Jun 12, 2022

I thought it's free to host extensions on web store. Is that not true?

You don't have to pay per extension, but there is a one time fee. It's cheap, and I might consider doing it, but I'm a bit wary about having to support two different browsers simultaneously.

@ghost
Copy link

ghost commented Jun 12, 2022

but I'm a bit wary about having to support two different browsers simultaneously.

I really appreciate you're atleast building .crx for chromium browsers too, which the support work is already done for us mate. Hosting on web store is just the last 10% task imho.
If you just need any help hosting & maintaining on web store, we could help you through donations, or find some maintainer for you...

@54ac
Copy link
Owner

54ac commented Jun 12, 2022

If you just need any help hosting & maintaining on web store, we could help you through donations, or find some maintainer for you...

My reservations stem from the fact that this is a personal project which I've been maintaining for my own use, and outsourcing it to maintainers or getting donations would make this addon a responsibility and, inevitably, a chore. If I didn't mind that I'd have uploaded it to the Web Store a long time ago.

@nammminn2
Copy link

https://share.cleanshot.com/VEnEf9 i got this error when i tried to load it to chrome

@Metamoran
Copy link

https://share.cleanshot.com/VEnEf9 i got this error when i tried to load it to chrome

Did you try to install it by clicking the CRX link in the releases page? If that's the case, right click and save the CRX file, open "chrome://extensions" in a new tab, then drag&drop said file in it instead. Worked fine for me.

PS: I just discovered this extension, and it works wonders in both Firefox and Chrome. Catches quite a few media streams other extensions don't. Thanks a lot, rowrawer.

@drdedus
Copy link

drdedus commented Nov 3, 2022

hello
is out there something similar for Android?
thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants