Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Add changes for chrome support #34

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

daviirodrig
Copy link
Contributor

I made two change for this to work on chrome, following the MDN guide building a cross-browser extension

  • Change API namespace to chrome.*
  • Change the asynchronous event handling to callbacks instead of promises

Resolves #9

@54ac
Copy link
Owner

54ac commented Jan 22, 2021

Have you tested whether it works at all?

@daviirodrig
Copy link
Contributor Author

Oh yes, sorry for not mentioning this in the PR. I tested on chrome and firefox and surprisingly both works well in my tests

I first started doing the porting just for my use but it turned to work so well with not so much changes that I made this pull request.

@54ac
Copy link
Owner

54ac commented Jan 22, 2021

Cool, that's quite surprising. If I ever decide to pay the registration fee, at least there won't be much work additional work to be done. Thanks.

@54ac 54ac merged commit 9efcc1a into 54ac:master Jan 22, 2021
@daviirodrig daviirodrig deleted the chrome-support branch January 22, 2021 19:24
@smaragdus
Copy link

@rowrawer

Any chance to publish a CRX file in the Releases page?

@54ac
Copy link
Owner

54ac commented Feb 17, 2021

I'll look into it.

@smaragdus
Copy link

@rowrawer

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Chrome
3 participants