feat: Add Theming options #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorbotamedi
commented
Mar 23, 2022
nfsxreloader
approved these changes
Mar 24, 2022
Merged
canastro
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to implement a solution to change the look and feel of the explorer widget.
Approach
Added a
DataExplorerThemeand a set of builders to allow library users to customize how each node is displayed.At first, I didn't add
DataExplorerThemeto anyInheritedWidget, I'm passing along constructors, I'm not sure what's the best solution here. We can discuss.We are going to implement golden tests in a future PR.
data_explorer_example.2022-03-23.18-31-56.mp4