fix: Search focus on key and values #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorbotamedi
force-pushed
the
fix-search-focus
branch
from
ad7080d
to
e723ade
Compare
| @@ -185,6 +185,7 @@ class NodeViewModelState extends ChangeNotifier { | |||
| /// The return [Map<String, NodeViewModelState>] has the same structure as | |||
| /// the decoded [object], except that every class, array and property is now | |||
| /// a [NodeViewModelState]. | |||
| @visibleForTesting | |||
There was a problem hiding this comment.
These tags can be removed right?
There was a problem hiding this comment.
no, I want to use these methods just for testing purposes.
nfsxreloader
approved these changes
Mar 25, 2022
victorbotamedi
force-pushed
the
fix-search-focus
branch
from
dffcb3c
to
7e98ebc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3
Context
The current search focus didn't know if the focus was on a key or value match, so when a node was focused and had matches in both key and value, both matches were being highlighted at the same time.