React 18, Upgrade Dependencies, Fix Copy/Paste #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. I have made my edits and merged your PR. |
|
Thanks for the quick merge, appreciate it! |
|
Sure. I have updated readme. I had to downgrade Storybook to version 6, due to some incompatibility issues. Will upgrade once its stable. |
|
When installing the package in the new 9+ version I cannot import, likely due to |
|
oops. Could you try with @rowsncolumns/grid@9.0.3 |
|
works now, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I've upgraded the dependencies and made sure it works with React 18. Also fixed some type errors I got during upgrading.
When trying the copy/paste the example I noticed that "[Object object]" was being pasted when copying cells. I tried to fix it, but I am not sure that the way I changed it is the way it was intended. Let me know if this should be handled differently.
I have also bumped the version to
9.0.0.