feat: work on the node component

rowyio · May 3, 2023 · 2921c17 · 2921c17
1 parent 2ffffdb
commit 2921c17
Show file tree

Hide file tree

Showing 5 changed files with 25 additions and 18 deletions.
diff --git a/src/components/Workflow/HttpTriggerNode.tsx b/src/components/Workflow/HttpTriggerNode.tsx
@@ -37,7 +37,7 @@ export default function HttpTriggerNode() {
           htmlFor="method"
           paramKey="method"
           paramConfig={{
-            type: "string",
+            type: "select",
             label: "Method",
             description: "The HTTP method to listen for",
             options: [

diff --git a/src/components/Workflow/NodeParam/NodeParam.tsx b/src/components/Workflow/NodeParam/NodeParam.tsx
@@ -8,7 +8,7 @@ export interface NodeParamProps {
 
   paramKey: string;
 
-  paramConfig: ParamConfig;
+  paramConfig?: ParamConfig;
 
   value: any;
 
@@ -22,7 +22,7 @@ const NodeParam: FC<NodeParamProps> = ({
   value,
   onChange,
 }) => {
-  if (paramConfig.type === "object" || paramConfig.type === "array")
+  if (paramConfig?.type === "object" || paramConfig?.type === "array")
     return (
       <NodeParamField
         htmlFor={htmlFor}
@@ -34,7 +34,7 @@ const NodeParam: FC<NodeParamProps> = ({
     );
   return (
     <Stack direction="row">
-      <Tooltip title={paramConfig.description}>
+      <Tooltip title={paramConfig?.description}>
         <Typography
           component="label"
           htmlFor={htmlFor}
@@ -44,16 +44,18 @@ const NodeParam: FC<NodeParamProps> = ({
           textOverflow="ellipsis"
           sx={{ whiteSpace: "nowrap" }}
         >
-          {paramConfig.label ?? paramKey}
+          {paramConfig?.label ?? paramKey}
         </Typography>
       </Tooltip>
-      <NodeParamField
-        htmlFor={htmlFor}
-        paramKey={paramKey}
-        paramConfig={paramConfig}
-        value={value}
-        onChange={onChange}
-      />
+      {paramConfig && (
+        <NodeParamField
+          htmlFor={htmlFor}
+          paramKey={paramKey}
+          paramConfig={paramConfig}
+          value={value}
+          onChange={onChange}
+        />
+      )}
     </Stack>
   );
 };

diff --git a/src/components/Workflow/NodeParam/NodeSelectParam.tsx b/src/components/Workflow/NodeParam/NodeSelectParam.tsx
@@ -1,7 +1,10 @@
 import { FormControl, InputBase, MenuItem, Select } from "@mui/material";
+import { ParamConfig } from "@src/components/Workflow/types";
 import { NodeParamProps } from "./NodeParam";
 
 interface NodeSelectParamProps extends NodeParamProps {
+  paramConfig: ParamConfig;
+
   value: string;
 
   onChange: (value: string) => void;

diff --git a/src/components/Workflow/ScriptNode.tsx b/src/components/Workflow/ScriptNode.tsx
@@ -77,9 +77,9 @@ const ScriptNode: FC<IScriptNodeProps> = () => {
 
       const { params, result, meta } = eval(scriptWithExports);
 
-      setParams(params);
+      setParams(params ?? {});
       setMeta(meta ?? {});
-      setResult(result);
+      setResult(result ?? {});
     } catch {}
   }, [script]);
 
@@ -133,7 +133,7 @@ const ScriptNode: FC<IScriptNodeProps> = () => {
         open={isEditing}
         onClose={() => setIsEditing(false)}
       >
-        <Stack width={440} p={2}>
+        <Stack width={480} p={2}>
           <Stack
             p={4}
             alignItems="center"

diff --git a/src/pages/Workflow/WorkflowPage.tsx b/src/pages/Workflow/WorkflowPage.tsx
@@ -30,9 +30,11 @@ export default function WorkflowPage() {
 
   return (
     <Stack alignItems="center">
-      <Button startIcon={<PlusIcon />} {...bindToggle(addTriggerPopupState)}>
-        Add trigger
-      </Button>
+      {false && (
+        <Button startIcon={<PlusIcon />} {...bindToggle(addTriggerPopupState)}>
+          Add trigger
+        </Button>
+      )}
       <Menu
         {...bindPopover(addTriggerPopupState)}
         anchorOrigin={{ horizontal: "center", vertical: "bottom" }}