Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Filter by" option to filter by the value of the cell #1251

Merged
merged 3 commits into from
Jun 2, 2023

Conversation

mnmt7
Copy link
Contributor

@mnmt7 mnmt7 commented May 9, 2023

Solves #1155

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2023 5:29am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) May 25, 2023 5:29am

@vercel
Copy link

vercel bot commented May 9, 2023

@mnmt7 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@mnmt7 mnmt7 changed the title "Filter by" option to filter by that value of the cell "Filter by" option to filter by the value of the cell May 9, 2023
@harinij harinij requested a review from shamsmosowi May 18, 2023 10:06
@harinij
Copy link
Member

harinij commented May 24, 2023

Hi @mnmt7 - Thank you for this PR. I tested this and it works well. Suggest a few minor changes.

  1. The older "Filter value" option needs to be removed. That option used to open the filter popup modal and then user had to click Filter button again for the filter to show up. This newer "Filter by" option is the expected behavior to quickly filter by a value in a table. So the older "Filter value" be deprecated to avoid double options.
Screenshot 2023-05-24 at 12 37 28 pm
  1. I also noticed that this "Filter by" option is disabled on fields which are spread out versions of a JSON - however manual filter on this field works well. It would be good if "Filter by" is enabled in this field as well as double checking for other field types. Quick video explainer.
Screenshot 2023-05-24 at 12 35 17 pm

@mnmt7
Copy link
Contributor Author

mnmt7 commented May 25, 2023

@harinij, I have implemented the changes. Please review when possible.

@harinij harinij requested a review from htuerker May 30, 2023 01:14
Copy link
Contributor

@htuerker htuerker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @mnmt7! Thanks for your contribution! LGTM!

@htuerker htuerker merged commit 23e29ca into rowyio:develop Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants