Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy/paste functionality for reference field #1320

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

mnmt7
Copy link
Contributor

@mnmt7 mnmt7 commented Jun 26, 2023

This PR adds copy/paste functionality for reference field through hotkeys and context menu actions.

Screencast.from.2023-06-26.14-35-19.webm

Closes #1319
/claim #1319

@vercel
Copy link

vercel bot commented Jun 26, 2023

@mnmt7 is attempting to deploy a commit to the Rowy Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Jun 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rowy-os ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 26, 2023 1:32pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
rowy-typedoc ⬜️ Ignored (Inspect) Jun 26, 2023 1:32pm

Copy link
Member

@shamsmosowi shamsmosowi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mnmt7 the copy implementation looks good, but what do you think about a regex pattern test implementation for paste? it should better to reduce specific field type code in the menu action also could be expanded to be used for paste implementations of other fields

@mnmt7
Copy link
Contributor Author

mnmt7 commented Jun 28, 2023

@shamsmosowi didn't get what you exactly want me to do? Can you please elaborate?

@shamsmosowi shamsmosowi merged commit fe47450 into rowyio:develop Jul 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants