Fix table sort does not work if table has formula column

[bofeiw]

Issue

Sort does not work if table has formula column.

Example: in this table setup, the right-most column is a formula column. The table sort is set to num descending, however the table UI displays rows order incorrectly.

Cause

In a commit related to formula field, it sets all rows to rowsLocal if there is formula column in the table.

rowy/src/atoms/tableScope/rowActions.ts

Lines 389 to 391 in 2715a80

	const isLocalRow =
	fieldName.startsWith("_rowy_formulaValue_") ||
	Boolean(find(tableRowsLocal, ["_rowy_ref.path", path]));

rowsLocal is designed to hold our of order rows that are supposed to be a very small set, and they are always displayed at the top of the table UI. They are not sorted or ordered.

rowy/src/atoms/tableScope/table.ts

Lines 170 to 197 in 0099bd1

	/** Combine tableRowsLocal and tableRowsDb */
	export const tableRowsAtom = atom<TableRow[]>((get) => {
	const rowsDb = get(tableRowsDbAtom);
	const rowsLocal = get(tableRowsLocalAtom);
	// Optimization: create Map of rowsDb by path to index for faster lookup
	const rowsDbMap = new Map<string, number>();
	rowsDb.forEach((row, i) => rowsDbMap.set(row._rowy_ref.path, i));
	// Loop through rowsLocal, which is usually the smaller of the two arrays
	const rowsLocalToMerge = rowsLocal.map((row, i) => {
	// If row is in rowsDb, merge the two
	// and remove from rowsDb to prevent duplication
	if (rowsDbMap.has(row._rowy_ref.path)) {
	const index = rowsDbMap.get(row._rowy_ref.path)!;
	const merged = updateRowData({ ...rowsDb[index] }, row);
	rowsDbMap.delete(row._rowy_ref.path);
	return merged;
	}
	return row;
	});
	// Merge the two arrays
	return [
	...rowsLocalToMerge,
	...rowsDb.filter((row) => rowsDbMap.has(row._rowy_ref.path)),
	];
	});

However, the commit would set all rows to rowsLocal, as a result, rows are displayed without going through filters or sorts.

Fix

Simply remove the condition for local row would fix this issue.

fieldName.startsWith("_rowy_formulaValue_")

After fix:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
rowy-os	✅ Ready (Inspect)	Visit Preview	Jan 23, 2024 0:00am
rowy-typedoc	✅ Ready (Inspect)	Visit Preview	Jan 23, 2024 0:00am