Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TMIO driver #336

Merged
merged 2 commits into from Jan 5, 2016
Merged

Introduce TMIO driver #336

merged 2 commits into from Jan 5, 2016

Conversation

173210
Copy link
Contributor

@173210 173210 commented Jan 5, 2016

No description provided.

Introduce TMIO driver instead of old sdmc.s
Build for ARM state, but use Thumb library because sbrk of ARM newlib
in devkitPro doesn't work.
@AlbertoSONIC
Copy link
Contributor

Are you really really really really sure this works fine?

@urherenow
Copy link
Contributor

I was just staring at this and wondering what the command line is to pull it onto my computer so I can build it and see what breaks... Do I need to do it manually?

@173210
Copy link
Contributor Author

173210 commented Jan 5, 2016

@AlbertoSONIC Really sure. I have tested so many times because it has many changes.
@urherenow

git fetch https://github.com/173210/rxTools.git master
git checkout FETCH_HEAD

@urherenow
Copy link
Contributor

It builds fine. Any particular way I need to test launching it or some functionality I should check?

AlbertoSONIC added a commit that referenced this pull request Jan 5, 2016
@AlbertoSONIC AlbertoSONIC merged commit 16ac215 into roxas75:master Jan 5, 2016
@urherenow
Copy link
Contributor

There are still so many compiler warnings in the code such as these:

x:/devkitPro/devkitARM/projects/rxTools/include/svc.h:26:25: warning: return type defaults to 'int' [-Wimplicit-int]
static inline _Noreturn svcExitThread()
^
source/payload/arm9/thread/thread.c:56:8: warning: return type defaults to 'int' [-Wimplicit-int]
static patchLabel()
^
source/payload/arm9/thread/thread.c: In function 'patchLabel':
source/payload/arm9/thread/thread.c:88:6: warning: 'return' with no value, in function returning non-void
return;

@AlbertoSONIC
Copy link
Contributor

@173210 Yeah I know, that's why I asked...

I've tested it aaaaaand......... Got three freezes... It doesn't work. And I merged it :/

@AlbertoSONIC
Copy link
Contributor

rxTools never boots its UI, the 3ds just freezes on a black screen...

@urherenow
Copy link
Contributor

yup. USA N3DS. Black screen from ctrbootmanager. And from HBL.

@AlbertoSONIC I hate to say it, but this is the second time you did this while I was actually at home and checking it out. You could have waited like 2 minutes more and saved yourself some trouble.

@urherenow
Copy link
Contributor

But I have tested building with the latest Cakehax and Cakebrah with devkitpro r45 (with the included ctrulib 1.0 and all) and it works perfectly. I don't understand why we aren't updating those submodules to use the latest tools. Whatever problems newer Cakehax was causing in the past, I don't think will happen right now since we have the Cakerop as a separate module at a specific commit.

So, leave CakesROP alone, but use the latest CakeHax and CakeBrah, along with updating to devkitarm r45 gets a big thumbs up from me.

@AlbertoSONIC
Copy link
Contributor

Ok I'll try ;)

@AlbertoSONIC
Copy link
Contributor

My extremely slow internet connection doesn't let me download devkitpro r45...

@urherenow
Copy link
Contributor

Just use the updater. It shouldn't download much if r44 is already installed.
To be clear, doing so does not fix this commit. It just works (before this commit), and may lead to better things down the road since ctrulib has matured so much.

@173210
Copy link
Contributor Author

173210 commented Jan 5, 2016

Well, you may test SDMC/NAND IO. I've tested with MSET downgrader, FBI injection, and NAND dumper.

@urherenow
Copy link
Contributor

@173210 how and on o3ds or n3ds? This commit completely broke rxtools. No data installation suite, no menu. Only black screen. USA N3ds.

@173210
Copy link
Contributor Author

173210 commented Jan 6, 2016

@urherenow Both on my old and new one. Anything use those devices, so the symptom is convincing, if the driver is corrupted.
Another possibility is corrupted ARM binary. The compile option has been changed to compile for ARM state because the TMIO driver uses mcr instruction.

@urherenow
Copy link
Contributor

Well, then you either didn't do a make clean, or you've introduced another build problem that breaks Windows because neither I nor @AlbertoSONIC can run rxtools from this source.

@173210
Copy link
Contributor Author

173210 commented Jan 6, 2016

@urherenow The OS shouldn't matter. The toolchain may do, but everyone uses devkitARM, right?

@urherenow
Copy link
Contributor

Yes. Trying to build without devkitARM would be frankenstein's nightmare...

@urherenow
Copy link
Contributor

@173210 Here's a text of my build. See if you spot anything fishy (and maybe see about some of the compiler warnings?). Either way, this simply does not run. I don't know how you say it's been working for you. Did you delete your whole 3DS /rxtools folder and set it up from scratch?

Build.txt
Edit:
WTF? Nothing shown on the console went into that text file... Here's the console output:

Build2.txt

@173210
Copy link
Contributor Author

173210 commented Jan 6, 2016

@urherenow Well, nothing is fishy. It's completely fine. No, I have not deleted the directory. I just simply overwrote code.bin.

@urherenow
Copy link
Contributor

Check my post again. Build2.txt And maybe you think it's working because you only replaced the code.bin. The /data folder is important, and pretty much all files in /lang were touched recently as well...

@173210
Copy link
Contributor Author

173210 commented Jan 6, 2016

@urherenow Can you set V=1 for make?

make all-target-rxtools V=1

@urherenow
Copy link
Contributor

Here it is. and since I only ever build by "make release", I'll try what I just built to see if it works or not.
testbuild.txt

WTF? This does not build all the things as make release does. This is way different.

@urherenow
Copy link
Contributor

Still a black screen after replacing the code.bin. Now it's your turn to delete your whole rxtools folder (you can save your firm folder) and replace the whole thing and say that it's working for you. If so, I'll just clone your tree and build it by itself and try it. (are you building from your tree or from current roxas75/master? maybe you forgot to add something to the pull request?)

@urherenow
Copy link
Contributor

Bump.
Sooo... @AlbertoSONIC are you going to revert this or what? @173210 and 1 other person insists that it works for them, so I seriously doubt anybody is looking into what went wrong.

Edit: Wait... @AlbertoSONIC are you still building with r44? I'm using r45, which shouldn't matter much, except that I'm using the latest Cakehax and Cakebrah. I just remembered that mid-kid changed what he was using for libkhax. libkhax could be the issue and I have a copy of the last cakebrah that did work for me. I'm late for work though, so I can play with it until lunch...

@AlbertoSONIC
Copy link
Contributor

Honestly I don't know. I believe in @173210 , if he tells me he'll fix this then it's ok, otherwise I must revert...

Btw, I think 173210's 3dses are special... Everything always works on them xD

@urherenow
Copy link
Contributor

edited my post. read again please. Late for work...

@AlbertoSONIC
Copy link
Contributor

I'm using devkitpro r45 with latest cakehax, cakebrah and libkhax. And it's not working.

Well, actually I'm still using the old 3dsx, but I think it's not related...

@urherenow
Copy link
Contributor

If you cloned Cakebrah separately (and recently), go into the Cakebrah folder and: git checkout 04dbd5c
Then go back to rxtools and make clean, then make release and see if that gets rid of the black screen or not.
That's what I planned on trying during my lunch anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants