Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Julia Makie examples to the tools.qmd #25

Merged
merged 4 commits into from
Aug 2, 2023
Merged

added Julia Makie examples to the tools.qmd #25

merged 4 commits into from
Aug 2, 2023

Conversation

storopoli
Copy link
Contributor

@storopoli storopoli commented Jul 29, 2023

We saw this nice initiative from RSS and since we have R and Python examples we decided to include Julia as well.

I am also correcting one spelling mistake in the Python HTML figure caption.

Cc @bkamins and @jkrumbiegel

@brtarran brtarran requested a review from nrennie July 31, 2023 14:10
@brtarran
Copy link
Collaborator

Thank you. This is great. Exactly the kind of thing we were hoping the community would want to contribute! Looks good to me. @nrennie - anything you want to add?

@nrennie
Copy link
Collaborator

nrennie commented Jul 31, 2023

This is great! I'm so excited to see community contributions like this (and to see more people using Julia). I've left a tiny comment about title alignment in one of the examples, but otherwise I'm happy with it.

Thanks so much for contributing!

@storopoli
Copy link
Contributor Author

@brtarran happy to collaborate

@nrennie I cannot find the comment

docs/tools.qmd Show resolved Hide resolved
@nrennie
Copy link
Collaborator

nrennie commented Jul 31, 2023

Thanks @storopoli - requested change should be showing now :)

@storopoli storopoli requested a review from nrennie July 31, 2023 20:10
Copy link
Collaborator

@nrennie nrennie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - looks good to me!

@brtarran brtarran merged commit 473779e into royal-statistical-society:main Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants