Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests require tcc executable in path #60

Closed
tranqui opened this issue Apr 7, 2018 · 3 comments
Closed

Unit tests require tcc executable in path #60

tranqui opened this issue Apr 7, 2018 · 3 comments
Assignees
Labels
bug Something isn't working windows Windows platform specific issue

Comments

@tranqui
Copy link

tranqui commented Apr 7, 2018

Unit tests fail on @merrygoat's windows machine because the unit test assumes the tcc executable is in the system path. Solution requires either an install feature (e.g. make install as suggested in #59), instructions for adding to the path or a workaround this requirement e.g. by directly locating the executable within the python front end.

@tranqui
Copy link
Author

tranqui commented Apr 7, 2018

Python front end should locate the executable inside the bin folder (if it has been built) as of 7a8a67d

@merrygoat do the unit tests run for you now?

@tranqui tranqui self-assigned this Apr 7, 2018
@merrygoat
Copy link
Contributor

They did not. I have made some modifications on the new branch "unit_tests".

For me the unit tests now pass on all three platforms. It would be good if you could have a look and see what you think. 7T is also now passing, hopefully that method is complete.

The integration tests are borked atm. because of adding the 7T, I will update these and the static_clust file Monday, integrating some of your ideas from the unit tests.

@tranqui
Copy link
Author

tranqui commented Apr 10, 2018

Confirmed that they are working. I have merged changes into devel branch.

@tranqui tranqui closed this as completed Apr 10, 2018
@tranqui tranqui added bug Something isn't working windows Windows platform specific issue labels Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working windows Windows platform specific issue
Projects
None yet
Development

No branches or pull requests

2 participants