-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build should include install option #59
Comments
My bad on copying the executable around, I will fix the integration tests to not do this. |
There are 3 stages to the make process. "cmake" should prepare the makefile, "make .." should actaully compile the file and then "make install" should do post compilation things. There are a couple of requests here:
|
@tranqui Three out of the above 4 bullet points have been done in the latest build but I don't think I can edit PYTHONPATH from a cmake file in a platform independent way - correct me if I'm wrong. |
That’s fantastic Peter :) Is it possible to move the library into the system python path then, so PYTHONPATH remains the same but it can still find the library? |
No because python path is not just a directory, it is a series of directories that are searched - if you haven't used use python much it may well be that python path is not defined. Can we just do it by adding current directory to sys.path in any Python scripts we provide? (as we have done in the unit tests). If users are writing their own scripts then they are probably sufficiently savvy to set PYTHONPATH. We can add a note to this effect in the readme too. |
Okay then, that seems like a reasonable compromise. I can write something in the readme for *NIX users if you like |
@FTurci comment in #50 thread:
The text was updated successfully, but these errors were encountered: