Fix possible crash found by fuzzer #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `skip` value is read from untrusted input and needs to be verified. This fix checks that `skip + 3` will not exceed `num_codes`, since we can't get a slice for `code_lengths[5..4]`. Fixes royaltm#7
|
Thanks! I suppose we don't have a test case binary? |
Thanks for looking at this so quickly. Yes, it's attached to #7. I think you found it after writing this. |
|
yes I did, thanks for the reply anyway! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
skipvalue is read from untrusted input and needs to be verified.This fix checks that
skip + 3will not exceednum_codes, since we can't get a slice forcode_lengths[5..4].Fixes #7