Improvements to aydin docstrings #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Thank you @royerloic ! I dropped a few comments to discuss if we can add further more info on certain places. After discussing these I think we can merge this. After the merge I will be making a follow-up PR to address changes on our documentation too and will update documentation webpage accordingly.
| @@ -43,8 +43,10 @@ def __init__( | |||
| balance_training_data : bool | |||
| Limits number training entries per target | |||
| value histogram bin. | |||
| (advanced) | |||
There was a problem hiding this comment.
I found myself toggling balance_training_data quite often while using Aydin. With certain images it helps a ton. Maybe we don't make it (advanced)? What do you think @royerloic ?
There was a problem hiding this comment.
Good idea! It is actually an important feature!
AhmetCanSolak
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved a lot of doc-strings, particularly for feature gen and FGR backends.