Skip to content

Commit

Permalink
[SPARK-13937][PYSPARK][ML] Change JavaWrapper _java_obj from static t…
Browse files Browse the repository at this point in the history
…o member variable

## What changes were proposed in this pull request?
In PySpark wrapper.py JavaWrapper change _java_obj from an unused static variable to a member variable that is consistent with usage in derived classes.

## How was this patch tested?
Ran python tests for ML and MLlib.

Author: Bryan Cutler <cutlerb@gmail.com>

Closes apache#11767 from BryanCutler/JavaWrapper-static-_java_obj-SPARK-13937.
  • Loading branch information
BryanCutler authored and roygao94 committed Mar 22, 2016
1 parent c606c0d commit 2ae11f5
Showing 1 changed file with 9 additions and 4 deletions.
13 changes: 9 additions & 4 deletions python/pyspark/ml/wrapper.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,15 @@ class JavaWrapper(Params):

__metaclass__ = ABCMeta

#: The wrapped Java companion object. Subclasses should initialize
#: it properly. The param values in the Java object should be
#: synced with the Python wrapper in fit/transform/evaluate/copy.
_java_obj = None
def __init__(self):
"""
Initialize the wrapped java object to None
"""
super(JavaWrapper, self).__init__()
#: The wrapped Java companion object. Subclasses should initialize
#: it properly. The param values in the Java object should be
#: synced with the Python wrapper in fit/transform/evaluate/copy.
self._java_obj = None

@staticmethod
def _new_java_obj(java_class, *args):
Expand Down

0 comments on commit 2ae11f5

Please sign in to comment.