Add VID Pattern Validation to CI Builds #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.) Makes VID Pattern checks fatal error if we have a bad pattern in source 2.) Adds an additional step the CI build process to acitvely verify all pattern files in all branches (including any new pull requests) The long in short of it is that we'll know if anyone tries to submit an improperly formatted VID pattern to avoid corrupting master pattern file.
|
Now that I'm looking at this, this might be better implemented as a check file. Thoughts? |
|
Yes, I think a check file is the best way to do this. "make check" is a standard makefile target, and that should run all the tests it can. I agree that a regex failure should be a fatal error, which will help catch these things if more people start to contribute patterns. |
added 4 commits
August 17, 2013 18:36
1.) Adds a handful of items to .gitignore that are generated with 'make check' so they don't get checked into source. 2.) Reverts recent change of WARN -> ERR back to WARN on pattern failures in ike-scan.c. This is to avoid having other checks that use vid-patterns from failing, which makes it less straight forward when we have pattern failures. 3.) Adds a make check to alert when patterns file contains an pattern that cannot be parsed.
|
I ended up reverting the behavior change I made WARN --> ERR because it was causing other checks that were unrelated to vendor ID patterns to fail. I felt it made more sense to revert back to a WARN and then just have the check verify for us. This way, if someone were to break the build with a bad vendor id pattern, it will be very clear why they build broke. |
royhills
added a commit
that referenced
this pull request
Aug 18, 2013
Add VID Pattern Validation to CI Builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check to validate VID patterns in the source tree
If a vid pattern fails to parse, it will "break" the build.