Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Google Chrome Extensions manifest v3 #9

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

roymckenzie
Copy link
Owner

- Using service worker pattern
- Fixed issue with message port closing
@roymckenzie
Copy link
Owner Author

@kip-13 do you mind reviewing this? I got around to fixing the issue mentioned in #8 by updating the extension to use the manifest v3 pattern with service workers. This should close the issue, but wanted another eye on it before I merge into master.

@kip-13
Copy link
Collaborator

kip-13 commented Oct 31, 2023

Hey @roymckenzie

I checked and it works really well. 🚀

I tried to fixed too days ago but without the upgrade to v3 and then I found an issue with the original medium post that distracted me:

image

The problem is because we do this.
I was trying to use a unicode as alternative and append in the text content directly but then I realized it's simpler for us to use a delay as an option, I did a PoC using this branch as base here #10

Copy link
Collaborator

@kip-13 kip-13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roymckenzie roymckenzie merged commit b49a7e5 into master Oct 31, 2023
@roymckenzie roymckenzie deleted the bugfix/runtime-error branch October 31, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants