Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider including Cargo.lock #10

Closed
fracek opened this issue Dec 16, 2021 · 2 comments · Fixed by #11
Closed

Consider including Cargo.lock #10

fracek opened this issue Dec 16, 2021 · 2 comments · Fixed by #11

Comments

@fracek
Copy link

fracek commented Dec 16, 2021

The Cargo Books recommends that end product applications (like cli tools) should include Cargo.lock into git. This makes the job of package maintainers easier (I'm making a package for NixOS).

@georgewhewell
Copy link

hey @fracek did you succeed in packaging this tool for nixos? i just tried to use it and (as expected) none of the binaries it downloads are functional. i think we need some sort of hook after it downloads a new version to patchelf the bin with nixos interpreter?

@fracek
Copy link
Author

fracek commented Jan 18, 2022

Yeah I haven't got around working on that. I was also wondering whta's the best way to force solc to look for the library in the right location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants