Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos support #36

Closed
d-xo opened this issue Mar 31, 2022 · 3 comments
Closed

nixos support #36

d-xo opened this issue Mar 31, 2022 · 3 comments

Comments

@d-xo
Copy link
Contributor

d-xo commented Mar 31, 2022

The binaries provided by svm-rs are dynamically linked and therefore must be patched to work correctly on nixos. I currently work around this by using DAPP_SOLC to point forge to the nixos compatible solc versions that we provide as part of dapptools, but a more integrated experience would be great.

Would you be open to supporting nixos directly in svm-rs? I would be happy to do the work and help maintain the integration.

@roynalnaruto
Copy link
Collaborator

Would you be open to supporting nixos directly in svm-rs? I would be happy to do the work and help maintain the integration.

@d-xo For sure. Feel free to create a PR, and we can support nixos. I'm not that familiar with it, since I don't use it. But happy to include support in svm.

@d-xo
Copy link
Contributor Author

d-xo commented Apr 13, 2022

That's great. Perhaps you could give me some pointers on how best to implement this?

I think the cleanest approach would be to apply, at runtime, a small patch to the binaries downloaded from soliditylang.org.

The patch would be applied via the instantiation of a nix expression. This would essentially boil down to a few invocations of nix command line tooling.

Which places in the code would need to be changed?

@roynalnaruto
Copy link
Collaborator

Closing as #48 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants