New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove cfg for defining function #55

Merged

roynalnaruto merged 1 commit into master from fix/generate-offline

Jul 25, 2022

Collaborator

roynalnaruto commented Jul 25, 2022 •

edited

Noticed this issue while publishing svm-builds: https://github.com/roynalnaruto/svm-rs/blob/master/svm-builds/build.rs#L151-L154

generate_offline is not compiled when _offline feature is not enabled. But the above snippet tries to use it.

I'm simply removing the #[cfg(feature = "_offline")] feature gate, so that generate_offline can be used in all cases where it's required.

@mattsse please have a look :)


          fix: remove cfg for defining function

1b3569b

mattsse approved these changes

View reviewed changes

Collaborator

mattsse commented Jul 25, 2022

nice catch, forgot to rm the cfg last night

roynalnaruto merged commit 2c9310d into master

roynalnaruto deleted the fix/generate-offline branch

July 25, 2022 14:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment