disable gray colors for solarized support #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AprilArcus, thanks for the pull request. I will merge it, but I will add a environment flag to change the theme completely for cases like yours. That way the original usage remains like it is now. Regards |
royriojas
added a commit
that referenced
this pull request
May 16, 2015
disable gray colors for solarized support
royriojas
pushed a commit
that referenced
this pull request
May 16, 2015
…he background. Fixes #2 Basically this fix removes the gray color if the environment variable `EFF_NO_GRAY` is set to the string `true`. this can be done very easily in bash doing: ```bash export EFF_NO_GRAY=true ```
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unfortunately,
chalk.gray(ansi "bright black") is used as the default background color by the popular "Solarized" terminal theme, and it therefore renders invisibly when specified without a background color. This PR simply disables the gray color. This was convenient for me and I thought I'd share it, but please feel free to reject with prejudice; I am aware that supporting all non-standard terminal configurations is impossible.