Adds Clever Dripper recipe #179
Conversation
|
Thanks @MarcBernstein |
Sounds good @rozPierog! Would you mind sharing the contact info (or method you used to work with them before) so that I can also reach out? I want to make sure they're good with it too. If not that's fine too, I should have reached out to them before creating this. I had mistakenly thought there was more of a blanket permission here in the app as long as proper attribution was given. |
|
No worries @MarcBernstein ! I used contact form on his site https://www.jameshoffmann.co.uk/contact-me and it was back in 2021-01-18, so long time ago, I just want to make sure that nothing has had changed. |
|
Great, that's sent off and we'll wait to see how they respond. Appreciate you walking me through that process. |
|
Ok, we have a green light from James, I'll move forward with code review and I hope we will merge it and release this week ☕️ |
| @@ -26,6 +26,7 @@ enum class RecipeIcon(@DrawableRes val icon: Int, @StringRes val nameResId: Int) | |||
| Siphon(R.drawable.recipe_icon_siphon, R.string.name_siphon), | |||
| Bripe(R.drawable.recipe_icon_bripe, R.string.name_bripe), | |||
| Cezve(R.drawable.recipe_icon_cezve, R.string.name_cezve), | |||
| CleverDripper(R.drawable.recipe_icon_drip, R.string.prepopulate_clever_dripper_name), | |||
There was a problem hiding this comment.
We shouldn't add new icons if they use the same drawable. In this case drip icon will show up twice in the icon picker
Maybe in the future I could hire Hubert again for new icons then I'll add Clever Dripper here.
There was a problem hiding this comment.
Maybe it would be best to change V60 icon into a generic drip icon, as there are a lot of similar looking drips on the market and it makes no sense to create an icon for every single one of them. WDYT?
| @@ -149,6 +149,12 @@ fun DefaultPreview() { | |||
| description = stringResource(R.string.prepopulate_aero_description), | |||
| recipeIcon = RecipeIcon.AeroPress, | |||
| ), | |||
| Recipe( | |||
There was a problem hiding this comment.
That was unnecessary but I appreciate the effort of adding it to the preview 🤎
There was a problem hiding this comment.
I'm gonna go ahead and merge it and fix my icon issue on my own. Once again thanks @MarcBernstein
Description
Adds Clever Dripper recipe from https://youtu.be/RpOdennxP24
Type of change
Checklist: