Provide functions to access watchdog scratch registers #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jannic
commented
Sep 6, 2023
rp2040-hal/src/watchdog.rs
Outdated
| @@ -93,6 +97,37 @@ impl Watchdog { | |||
| self.watchdog.ctrl.write(|w| w.enable().bit(bit)) | |||
| } | |||
|
|
|||
| /// Read a scratch register | |||
| pub fn read_scratch(&self, idx: u8) -> Result<u32, NoSuchRegister> { | |||
There was a problem hiding this comment.
Request for feedback: Is the use of idx: u8 with the possibility of a NoSuchRegister error a good choice?
Or should the parameter be an enum listing the existing registers, so an error becomes impossible?
There was a problem hiding this comment.
Would it make sense to expose them as a sized array? (May require a change in the PAC)
There was a problem hiding this comment.
I considered that, but without a good use case I didn't want to do the PAC modification.
However I tried the enum variant and I think it's better than the idx: u8 one. I'll push the update as soon as I find the time to actually test it.
thejpster
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.