Add from_installed_program with correct shift direction #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing function from_program uses the "wrong" shift direction, the default is different from what the RP2040 does. This is confusing and can lead to difficult to debug errors. (This is how this difference was found.) To avoid a subtle breaking change by just fixing the default, introduce a new function from_installed_program with the correct default value, and deprecate the old one.
jannic
force-pushed
the
change-default-shift-direction
branch
from
6fdeda6
to
50583b2
Compare
jannic
changed the title
thejpster
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing function
from_programuses the "wrong" shift direction, the default is different from what the RP2040 does. This is confusing and can lead to difficult to debug errors. (This is how this difference was found.)To avoid a subtle breaking change by just fixing the default, introduce a new function
from_installed_programwith the correct default value, and deprecate the old one.