Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rustc nightly for cargo udeps #763

Merged
merged 3 commits into from
Feb 10, 2024

Conversation

ithinuel
Copy link
Member

@ithinuel ithinuel commented Feb 6, 2024

There’s no obvious reason to keep on-target-tests excluded from the
workspace. Plus, this simplifies significantly the github workflows.
They have been updated and now build fine
Copy link
Member

@thejpster thejpster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Who originally removed the on target tests from the workspace?

@jannic
Copy link
Member

jannic commented Feb 10, 2024

Who originally removed the on target tests from the workspace?

See #762

Sorry, splitting the large pull-request into multiple smaller ones maybe was a bad idea. I thought it would make reviewing easier, but it seems like it caused some confusion.

@jannic jannic merged commit d3a2f68 into rp-rs:main Feb 10, 2024
6 checks passed
@ithinuel ithinuel deleted the bump-rustc-nightly-for-cargo-udeps branch February 10, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants